-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate function declarations-v5 #12015
Remove duplicate function declarations-v5 #12015
Conversation
NOTE: This PR may contain new authors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12015 +/- ##
==========================================
+ Coverage 83.22% 83.25% +0.02%
==========================================
Files 910 910
Lines 258136 258136
==========================================
+ Hits 214831 214899 +68
+ Misses 43305 43237 -68
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the changes here look good, a recent merge of other changes has resulted in conflicts that will have to be solved.
This can be done by rebasing your work on top of the latest changes in master.
Can you please do that and submit a new PR? :)
okay |
Ticket: #7297
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7297
Describe changes:
-Remove duplicate function declarations