Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate function declarations-v5 #12015

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Oct 23, 2024

Ticket: #7297

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7297

Describe changes:

-Remove duplicate function declarations

Copy link

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (30806ce) to head (94ef040).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12015      +/-   ##
==========================================
+ Coverage   83.22%   83.25%   +0.02%     
==========================================
  Files         910      910              
  Lines      258136   258136              
==========================================
+ Hits       214831   214899      +68     
+ Misses      43305    43237      -68     
Flag Coverage Δ
fuzzcorpus 61.49% <ø> (+0.08%) ⬆️
livemode 19.41% <ø> (+0.03%) ⬆️
pcap 44.42% <ø> (-0.04%) ⬇️
suricata-verify 62.73% <ø> (-0.02%) ⬇️
unittests 59.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 23, 2024
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks :)

@victorjulien victorjulien modified the milestone: 8.0 Oct 24, 2024
@jufajardini jufajardini added the needs rebase Needs rebase to master label Oct 24, 2024
@jufajardini jufajardini self-requested a review October 24, 2024 19:04
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the changes here look good, a recent merge of other changes has resulted in conflicts that will have to be solved.

This can be done by rebasing your work on top of the latest changes in master.

Can you please do that and submit a new PR? :)

@Nancyenos
Copy link
Contributor Author

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

3 participants