Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: Add linktype name #11670

Closed
wants to merge 1 commit into from
Closed

output: Add linktype name #11670

wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11584

Issue: 6954

This commit adds the linktype name to the output stream. The name is determined from the pcap utility function pcap_datalink_val_to_name

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6954

Describe changes:

  • Include the linktype name alongside linktype
  • Update the schema with linktype_name

Updates:

  • Rebase

Provide values to any of the below to override the defaults.

SV_BRANCH=OISF/suricata-verify#2023

Issue: 6954

This commit adds the linktype name to the output stream. The name is
determined from the pcap utility function pcap_datalink_val_to_name
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (304271e) to head (abe809e).
Report is 168 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11670      +/-   ##
==========================================
- Coverage   82.61%   82.60%   -0.01%     
==========================================
  Files         919      919              
  Lines      248997   249000       +3     
==========================================
- Hits       205717   205698      -19     
- Misses      43280    43302      +22     
Flag Coverage Δ
fuzzcorpus 60.88% <66.66%> (+<0.01%) ⬆️
livemode 18.66% <0.00%> (-0.01%) ⬇️
pcap 44.13% <0.00%> (-0.02%) ⬇️
suricata-verify 61.87% <66.66%> (-0.03%) ⬇️
unittests 59.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 22279

@catenacyber
Copy link
Contributor

I did not do a full review, but this looks good to me

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work.

CI : ✅
Code : good
Commits segmentation : ok
Commit messages : ok
Git ID set : looks fine for me
CLA : you already contributed
Doc update : ok
Redmine ticket : fair enough for me
Rustfmt : no rust
Tests : SV looks good
Dependencies added: none

@victorjulien victorjulien added this to the 8.0 milestone Sep 11, 2024
@victorjulien
Copy link
Member

Not as portable as we thought, sadly
image
OpenBSD

@victorjulien victorjulien removed this from the 8.0 milestone Sep 12, 2024
@victorjulien victorjulien self-requested a review September 12, 2024 04:52
@catenacyber
Copy link
Contributor

Not as portable as we thought, sadly image OpenBSD

This looks expected to me cf #11584 (comment)

@victorjulien
Copy link
Member

Not as portable as we thought, sadly image OpenBSD

This looks expected to me cf #11584 (comment)

It was the hope that a string version would be portable.

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to come up with our own OS independent mapping

@jlucovsky
Copy link
Contributor Author

Continued in #11994

@jlucovsky jlucovsky closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants