-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
output: Add linktype name #11670
output: Add linktype name #11670
Conversation
Issue: 6954 This commit adds the linktype name to the output stream. The name is determined from the pcap utility function pcap_datalink_val_to_name
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11670 +/- ##
==========================================
- Coverage 82.61% 82.60% -0.01%
==========================================
Files 919 919
Lines 248997 249000 +3
==========================================
- Hits 205717 205698 -19
- Misses 43280 43302 +22
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 22279 |
I did not do a full review, but this looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work.
CI : ✅
Code : good
Commits segmentation : ok
Commit messages : ok
Git ID set : looks fine for me
CLA : you already contributed
Doc update : ok
Redmine ticket : fair enough for me
Rustfmt : no rust
Tests : SV looks good
Dependencies added: none
This looks expected to me cf #11584 (comment) |
It was the hope that a string version would be portable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to come up with our own OS independent mapping
Continued in #11994 |
Continuation of #11584
Issue: 6954
This commit adds the linktype name to the output stream. The name is determined from the pcap utility function pcap_datalink_val_to_name
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6954
Describe changes:
Updates:
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2023