Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/analyzer: add more details for the tcp ack keyword - v5 #10266

Closed
wants to merge 1 commit into from

Conversation

0xEniola
Copy link
Contributor

@0xEniola 0xEniola commented Jan 27, 2024

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6354

Previous PR: #9659

Describe changes:

  • Included the detect-tcp-ack header.
  • Made a mistake submitting this PR before the Suricata-verify PR; had to resubmit so the CI will pick it.

Output:

{
  "raw": "alert tcp any any -> any any (msg:\"Testing ack\"; ack:782; sid:1;)",
  "id": 1,
  "gid": 1,
  "rev": 0,
  "msg": "Testing ack",
  "app_proto": "unknown",
  "requirements": [],
  "type": "pkt",
  "flags": [
    "src_any",
    "dst_any",
    "sp_any",
    "dp_any",
    "need_packet",
    "toserver",
    "toclient"
  ],
  "pkt_engines" : [
    {
      "name": "packet",
      "is_mpm": false
    }
  ],
  "frame_engines": [],
  "lists": {
    "packet": {
      "matches": [
        {
          "name": "tcp.ack",
          "ack": {
            "number": 782
          }
        }
      ]
    }
   }
}
SV_BRANCH=https://github.com/OISF/suricata-verify/pull/1627

Issue: 6354
Added the DETECT_ACK case to detect-engine-analyzer.c
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3b3c11) 82.28% compared to head (83c7f92) 82.35%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10266      +/-   ##
==========================================
+ Coverage   82.28%   82.35%   +0.07%     
==========================================
  Files         977      977              
  Lines      271950   271956       +6     
==========================================
+ Hits       223784   223982     +198     
+ Misses      48166    47974     -192     
Flag Coverage Δ
fuzzcorpus 63.59% <0.00%> (+0.19%) ⬆️
suricata-verify 61.52% <100.00%> (+<0.01%) ⬆️
unittests 62.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks and kudos! :)

@jufajardini
Copy link
Contributor

Re-triggered CI runs to see if they're still green with the new SV PR that was linked to it.

@victorjulien victorjulien added this to the 8.0 milestone Apr 8, 2024
@victorjulien
Copy link
Member

Merged in #10790, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants