-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect/analyzer: add more details for the tcp ack keyword - v5 #10266
Conversation
Issue: 6354 Added the DETECT_ACK case to detect-engine-analyzer.c
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10266 +/- ##
==========================================
+ Coverage 82.28% 82.35% +0.07%
==========================================
Files 977 977
Lines 271950 271956 +6
==========================================
+ Hits 223784 223982 +198
+ Misses 48166 47974 -192
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks and kudos! :)
Re-triggered CI runs to see if they're still green with the new SV PR that was linked to it. |
Merged in #10790, thanks! |
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6354
Previous PR: #9659
Describe changes:
Output: