Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua: Move to lua 5.4 and include by default v5 #10263

Closed
wants to merge 7 commits into from
Closed

lua: Move to lua 5.4 and include by default v5 #10263

wants to merge 7 commits into from

Conversation

J0eJ0h
Copy link
Contributor

@J0eJ0h J0eJ0h commented Jan 26, 2024

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4776

Describe changes:

  • Move to using lua 5.4
  • Remove luajit support and --enable-luajit configure option
  • Change --enable-lua option to --disable-lua and build with lua by default
  • CI Fixes

#10255 with:

  • All internal references to luajit removed.

@J0eJ0h J0eJ0h mentioned this pull request Jan 26, 2024
Closed
@github-actions GitHub Actions
Copy link

NOTE: This PR may contain new authors.

This was referenced Jan 29, 2024
Closed
Closed
@J0eJ0h J0eJ0h mentioned this pull request Feb 5, 2024
Closed
@catenacyber catenacyber added the needs rebase Needs rebase to master label Feb 29, 2024
jlucovsky
jlucovsky reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jlucovsky jlucovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This standardizes on lua5.4 -- I think that should be mentioned in the release notes or somewhere more appropriate.

.github/workflows/builds.yml
@@ -1559,7 +1559,7 @@ jobs:
chmod 755 $HOME/.cargo/bin/cbindgen
echo "$HOME/.cargo/bin" >> $GITHUB_PATH
- run: ./autogen.sh
- run: ./configure --with-gnu-ld --enable-fuzztargets --disable-shared --enable-gccprotect
- run: ./configure --with-gnu-ld --enable-fuzztargets --disable-shared --enable-gccprotect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra whitespace after --disable-shared

catenacyber
catenacyber requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the Github status as it needs a rebase, and there are comments to be taken care of

@jasonish jasonish mentioned this pull request Apr 10, 2024
Closed
@jasonish
Copy link
Member

Continued at #10801.

@jasonish jasonish closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlucovsky jlucovsky jlucovsky left review comments

@catenacyber catenacyber catenacyber requested changes

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
needs rebase Needs rebase to master
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@J0eJ0h @jasonish @catenacyber @jlucovsky