Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose: codeql security-extended suite #10258

Closed
wants to merge 1 commit into from

Conversation

0xEniola
Copy link
Contributor

Add the CodeQL security-extended suite to the CodeQL workflow configuration.

The security-extended query suite consists of all the queries in the default query suite, with addition of queries with slightly lower precision and severity, although, relative to the default query suite, the security-extended suite may return a greater number of false positive code scanning results.

It will allow us to catch likely flaws in the codebase that we may have missed during development, and flaws that are not checked for with the default suite, hence, allowing for greater hardening of Suricata, and eradicating potential threats.

Add the CodeQL security-extended suite to
the CodeQL workflow configuration.
@0xEniola 0xEniola requested a review from jasonish as a code owner January 26, 2024 08:13
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit should say: codeql: add security-extended query.

@inashivb inashivb requested a review from catenacyber January 26, 2024 08:25
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3b3c11) 82.28% compared to head (392056c) 82.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10258      +/-   ##
==========================================
- Coverage   82.28%   82.27%   -0.01%     
==========================================
  Files         977      977              
  Lines      271950   271950              
==========================================
- Hits       223784   223760      -24     
- Misses      48166    48190      +24     
Flag Coverage Δ
fuzzcorpus 63.39% <ø> (-0.01%) ⬇️
suricata-verify 61.50% <ø> (-0.02%) ⬇️
unittests 62.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@0xEniola
Copy link
Contributor Author

Commit should say: codeql: add security-extended query.

OK!

Thank you.

@0xEniola
Copy link
Contributor Author

Commit should say: codeql: add security-extended query.

should I just leave it at query? And not add suite?
Because it's not a query, it's a suite of queries.

@inashivb
Copy link
Member

Commit should say: codeql: add security-extended query.

should I just leave it at query? And not add suite? Because it's not a query, it's a suite of queries.

Please add it then. :)

@0xEniola 0xEniola closed this Jan 26, 2024
@0xEniola 0xEniola deleted the add-codeql-security-extended branch February 9, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants