detect: app-layer-protocol keyword with modes #10256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
requested review from
jufajardini and
victorjulien
as code owners
|
WARNING:
Pipeline 17767 |
catenacyber
force-pushed
the
detect-app-layer-proto-4921-v1
branch
from
25df136 to
193959f
Compare
|
Draft because of messy history, checking for CI |
Ticket: 4921 app-layer-protocol keyword accept an optional mode to precise which protocol we want to match: toclient, toserver, final, or original
catenacyber
force-pushed
the
detect-app-layer-proto-4921-v1
branch
from
193959f to
f4ee0ae
Compare
|
WARNING:
Pipeline 17820 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10256 +/- ##
==========================================
+ Coverage 82.28% 82.30% +0.01%
==========================================
Files 977 977
Lines 271950 272008 +58
==========================================
+ Hits 223784 223886 +102
+ Misses 48166 48122 -44
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 17821 |
|
Title doesn't give me any idea what this is about, so I guess it would be good to pick a better title/subject here |
Tried better in #10296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4921
Describe changes:
Allows especially to consider the final protocol to write rules like
alert tcp any any -> any 80 (msg:"non-HTTP traffic over HTTP standard port"; flow:to_server; app-layer-protocol:!http; sid:1;)OISF/suricata-verify#1613