next/271/70x/20240125/v1 #10253
Merged
next/271/70x/20240125/v1 #10253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6656 (cherry picked from commit d321838)
The shutdown(2) syscall would always return ENOTCONN for FreeBSD 11, FreeBSD 12, FreeBSD 13 and FreeBSD 14. It could do some action on the socket in the kernel in FreeBSD 10 and before, did not test. (cherry picked from commit b239e88)
When running Suricata in XDP bypass mode (bypass: yes), Suricata started up with error: Error: threads: thread "FB" failed to start in time: flags 0003 "FB" thread does not transition from THV_INIT_DONE to THV_RUNNING. Set "FB" thread THV_RUNNING state in BypassedFlowManager(). Bug: OISF#6254 Signed-off-by: Vincent Li <[email protected]> (cherry picked from commit f80d26d)
Previous integration of hugepage analysis only fetched data from /proc/meminfo. However this proved to be often deceiving mainly for providing only global information and not taking into account different hugepage sizes (e.g. 1GB hugepages) and different NUMA nodes. Ticket: OISF#6697 (cherry picked from commit ca6f7c2)
Remove references that are mentioning Suricata 3 or less As a note - only one Suricata 4 reference found: (suricata-yaml.rst:"In 4.1.x") Fast pattern selection criteria can be internally found by inspecting SupportFastPatternForSigMatchList and SigTableSetup functions. Ticket: OISF#6699 (cherry picked from commit 6e4cc79)
Move to libhtp to the 0.5.x branch instead of 0.5.45. (cherry picked from commit c3b3c11)
"sigerror_ok" and "sigerror_requires" were not being reset after each rule which could lead to a rule load error being incorrectly tracked as skipped rather than failed. Also initialize "skippedsigs" to 0 along with "goodsigs" and "badsigs", while not directly related to this issue, could also throw off some stats. Ticket: OISF#6710 (cherry picked from commit de3cbe4)
(cherry picked from commit 8bf8131)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #10253 +/- ##
==============================================
+ Coverage 82.17% 82.21% +0.04%
==============================================
Files 974 975 +1
Lines 274579 274789 +210
==============================================
+ Hits 225639 225923 +284
+ Misses 48940 48866 -74
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Jan 25, 2024
This was referenced Jan 25, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: