pgsql: don't log passsword msg if password disabled (7.0.x backport) - v1 #10009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the logging of the password is disabled, there isn't much point in logging the password message itself. (cherry picked from commit bdec2d8)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #10009 +/- ##
==============================================
- Coverage 82.50% 82.46% -0.05%
==============================================
Files 968 968
Lines 273870 273869 -1
==============================================
- Hits 225957 225836 -121
- Misses 47913 48033 +120
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16944 |
jasonish
approved these changes
Dec 11, 2023
victorjulien
approved these changes
Dec 12, 2023
|
Merged in #10038, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
backport - https://redmine.openinfosecfoundation.org/issues/6604
original - https://redmine.openinfosecfoundation.org/issues/6603
Describe changes: