Skip to content

Commit

Permalink
detect: header_lowercase transform
Browse files Browse the repository at this point in the history
Ticket: 6290
(cherry picked from commit 32cce12)
  • Loading branch information
catenacyber authored and victorjulien committed Dec 12, 2023
1 parent 2e96720 commit e974dbe
Show file tree
Hide file tree
Showing 6 changed files with 139 additions and 0 deletions.
16 changes: 16 additions & 0 deletions doc/userguide/rules/transforms.rst
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,19 @@ Example::

alert http any any -> any any (msg:"HTTP with xor"; http.uri; \
xor:"0d0ac8ff"; content:"password="; sid:1;)

header_lowercase
----------------

This transform is meant for HTTP/1 HTTP/2 header names normalization.
It lowercases the header names, while keeping untouched the header values.

The implementation uses a state machine :
- it lowercases until it finds ``:```
- it does not change until it finds a new line and switch back to first state

This example alerts for both HTTP/1 and HTTP/2 with a authorization header
Example::

alert http any any -> any any (msg:"HTTP authorization"; http.header_names; \
header_lowercase; content:"authorization:"; sid:1;)
2 changes: 2 additions & 0 deletions src/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ noinst_HEADERS = \
detect-tos.h \
detect-transform-compress-whitespace.h \
detect-transform-dotprefix.h \
detect-transform-header-lowercase.h \
detect-transform-md5.h \
detect-transform-pcrexform.h \
detect-transform-sha1.h \
Expand Down Expand Up @@ -948,6 +949,7 @@ libsuricata_c_a_SOURCES = \
detect-tos.c \
detect-transform-compress-whitespace.c \
detect-transform-dotprefix.c \
detect-transform-header-lowercase.c \
detect-transform-md5.c \
detect-transform-pcrexform.c \
detect-transform-sha1.c \
Expand Down
2 changes: 2 additions & 0 deletions src/detect-engine-register.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@
#include "detect-transform-pcrexform.h"
#include "detect-transform-urldecode.h"
#include "detect-transform-xor.h"
#include "detect-transform-header-lowercase.h"

#include "util-rule-vars.h"

Expand Down Expand Up @@ -696,6 +697,7 @@ void SigTableSetup(void)
DetectTransformPcrexformRegister();
DetectTransformUrlDecodeRegister();
DetectTransformXorRegister();
DetectTransformHeaderLowercaseRegister();

DetectFileHandlerRegister();

Expand Down
1 change: 1 addition & 0 deletions src/detect-engine-register.h
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ enum DetectKeywordId {
DETECT_TRANSFORM_PCREXFORM,
DETECT_TRANSFORM_URL_DECODE,
DETECT_TRANSFORM_XOR,
DETECT_TRANSFORM_HEADER_LOWERCASE,

DETECT_AL_IKE_EXCH_TYPE,
DETECT_AL_IKE_SPI_INITIATOR,
Expand Down
88 changes: 88 additions & 0 deletions src/detect-transform-header-lowercase.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
/* Copyright (C) 2023 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/

/**
* \file
*
* \author Philippe Antoine <[email protected]>
*
* Implements the header_lowercase transform keyword with option support
*/

#include "suricata-common.h"
#include "detect.h"
#include "detect-engine.h"
#include "detect-parse.h"
#include "detect-transform-header-lowercase.h"

/**
* \internal
* \brief Apply the header_lowercase keyword to the last pattern match
* \param det_ctx detection engine ctx
* \param s signature
* \param optstr options string
* \retval 0 ok
* \retval -1 failure
*/
static int DetectTransformHeaderLowercaseSetup(
DetectEngineCtx *de_ctx, Signature *s, const char *optstr)
{
SCEnter();
int r = DetectSignatureAddTransform(s, DETECT_TRANSFORM_HEADER_LOWERCASE, NULL);
SCReturnInt(r);
}

static void DetectTransformHeaderLowercase(InspectionBuffer *buffer, void *options)
{
const uint8_t *input = buffer->inspect;
const uint32_t input_len = buffer->inspect_len;
if (input_len == 0) {
return;
}
uint8_t output[input_len];

// state 0 is header name, 1 is header value
int state = 0;
for (uint32_t i = 0; i < input_len; i++) {
if (state == 0) {
if (input[i] == ':') {
output[i] = input[i];
state = 1;
} else {
output[i] = u8_tolower(input[i]);
}
} else {
output[i] = input[i];
if (input[i] == '\n') {
state = 0;
}
}
}
InspectionBufferCopy(buffer, output, input_len);
}

void DetectTransformHeaderLowercaseRegister(void)
{
sigmatch_table[DETECT_TRANSFORM_HEADER_LOWERCASE].name = "header_lowercase";
sigmatch_table[DETECT_TRANSFORM_HEADER_LOWERCASE].desc =
"modify buffer via lowercaseing header names";
sigmatch_table[DETECT_TRANSFORM_HEADER_LOWERCASE].url =
"/rules/transforms.html#header_lowercase";
sigmatch_table[DETECT_TRANSFORM_HEADER_LOWERCASE].Transform = DetectTransformHeaderLowercase;
sigmatch_table[DETECT_TRANSFORM_HEADER_LOWERCASE].Setup = DetectTransformHeaderLowercaseSetup;
sigmatch_table[DETECT_TRANSFORM_HEADER_LOWERCASE].flags |= SIGMATCH_NOOPT;
}
30 changes: 30 additions & 0 deletions src/detect-transform-header-lowercase.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/* Copyright (C) 2023 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/

/**
* \file
*
* \author Philippe Antoine <[email protected]>
*/

#ifndef __DETECT_TRANSFORM_HEADER_LOWERCASE_H__
#define __DETECT_TRANSFORM_HEADER_LOWERCASE_H__

/* prototypes */
void DetectTransformHeaderLowercaseRegister(void);

#endif /* __DETECT_TRANSFORM_HEADER_LOWERCASE_H__ */

0 comments on commit e974dbe

Please sign in to comment.