-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next/sv/703/20250128/v1 #2261
Merged
victorjulien
merged 12 commits into
OISF:master
from
victorjulien:next/sv/703/20250128/v1
Jan 28, 2025
Merged
next/sv/703/20250128/v1 #2261
victorjulien
merged 12 commits into
OISF:master
from
victorjulien:next/sv/703/20250128/v1
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for verifying matching packet flows when including and excluding pkt recursion from flow matching. Bug: #6260
To accompany rule types documentation. Added these separately, as they require extra config files. As the test name still includes `rule-types`, it's still possible to both batches of tests at once. Related to Task #https://redmine.openinfosecfoundation.org/issues/7031
Add test for the app_tx rule type for the engine-analysis report to accompany rule types documentation. Related to Task #7031
Add tests for the app_layer rule type for the engine-analysis report to accompany rule types documentation. Related to Task #7031
Test protocol detection only engine-analysis tests to accompany rule types documentation. Related to Task #7031
Add engine-analysis tests for like_ip_only rule type, to accompany rule types documentation. Related to Task #7031
To accompany rule types documentation. Related to Task #7031
To accompany rule types documentation. Related to Task #7031
To accompany rule types documentation. Related to Task #7031
To accompany the Rule Types documentation. Related to Task #7031
To accompany Rule Types documentation. Related to Task #7031
catenacyber
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks consistent with approved PRs
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: