SDP: add tests for sticky buffers v3 #2210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Suricata PR: OISF/suricata#12327 |
catenacyber
approved these changes
Jan 28, 2025
catenacyber
reviewed
Jan 28, 2025
| Content-Length: 272\x0d | ||
| Contact: <sip:[email protected]>\x0d | ||
| Max-Forwards: 70\x0d | ||
| Allow: INVITE, ACK, CANCEL, BYE, REFER, OPTIONS, NOTIFY, INFO\x0d |
There was a problem hiding this comment.
nit : do you have a pcap that is real traffic captured from real client and server (not synthetic one ?)
catenacyber
reviewed
Jan 28, 2025
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 |
There was a problem hiding this comment.
nit you can test that sdp metadata is logged with the alert and matches
and other nit : you can test that some other signatures do not match §so that we do not have FPs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: