test: add test for vlan.id - v8 #2194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkakiAlice
force-pushed
the
detect-vlan-id-1065-v8
branch
from
48117a3 to
bac0693
Compare
5 tasks
catenacyber
reviewed
Dec 18, 2024
| alert ip any any -> any any (msg:"VLAN ID at layer 1 is less than 400"; vlan.id:<400,1; sid:8;) | ||
| alert ip any any -> any any (msg:"One Vlan ID is greater than or equal to 200"; vlan.id:>=0xC8; sid:9;) | ||
| alert ip any any -> any any (msg:"All the Vlan IDs are greater than 100"; vlan.id:>100,all; sid:10;) | ||
| alert ip any any -> any any (msg:"Packet has 3 VLAN layers"; vlan.id:3,count; sid:11;) |
There was a problem hiding this comment.
This PR is really fine.
You could also add prefilter in some signatures, like vlan.id:>100,all; prefilter;
You could also add a signature with vlan.id:0,count; and a packet without vlan
catenacyber
approved these changes
Dec 18, 2024
jufajardini
requested changes
Dec 18, 2024
Comment on lines
+1
to
+2
| #! /usr/bin/env python3 | ||
| from scapy.all import * |
There was a problem hiding this comment.
Can we also have the scapy version as a comment here in the script? Makes it easier to not lose the information :)
| @@ -0,0 +1,3 @@ | |||
| Test for checking the working of vlan.id keyword by creating rules and matching a crafted packet against them. The packet is an ICMP packet with 3 different VLAN ids [200,300,400]. | |||
There was a problem hiding this comment.
As with the docs, these look better if we keep lines to a certain character count limit.
Let's try around 79 or 80?
| @@ -0,0 +1,3 @@ | |||
| Test for checking the working of vlan.id keyword by creating rules and matching a crafted packet against them. The packet is an ICMP packet with 3 different VLAN ids [200,300,400]. | |||
|
|
|||
| PCAP created with scapy 2.5.0. | |||
There was a problem hiding this comment.
Could you add the redmine ticket link reference here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1065
Description:
test.rules changes:
vlan.id:!500;tovlan.id:!500,all;: line 6count: line 11test.yaml changes:
countrule : line 62Redmine ticket: https://redmine.openinfosecfoundation.org/issues/1065
Previous PR: #2188
Suricata PR: OISF/suricata#12301