Bug 7318/v4 #2174
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Test Description | ||
|
|
||
| engine analysis complementary test for tls-extra-alert. | ||
|
|
||
| ## Related issues | ||
|
|
||
| None so far. State: Trying to establish what's the issue. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| alert tcp any any -> any 443 (flow: to_server; flags: S,CE; flowbits:set, tls_tracker; flowbits: noalert; sid:09901001; ) | ||
| alert tcp any any -> any 443 (flowbits:isset, tls_tracker; content: "|15 03 01 00 02 02|"; startswith; flowbits:set, tls_error; sid:09901031; rev:1; msg:"TLS 1.2 Fatal Alert (outgoing packet)"; ) | ||
| alert tcp any 443 -> any any (flowbits:isset, tls_tracker; content: "|15 03 01 00 02 02|"; startswith; flowbits:set, tls_error; sid:09901032; rev:1; msg:"TLS 1.2 Fatal Alert (incoming packet)"; ) | ||
| alert tcp any any -> any 443 (flow: to_server; flowbits:isset, tls_error; sid:09901033; rev:1; msg:"Allow TLS error handling (outgoing packet)"; ) | ||
| alert tcp any 443 -> any any (flow: to_client; flowbits:isset, tls_error; sid:09901034; rev:1; msg:"Allow TLS error handling (incoming packet)"; ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,229 @@ | ||
| requires: | ||
| min-version: 8 | ||
|
|
||
| args: | ||
| - --simulate-ips | ||
| - --engine-analysis | ||
|
|
||
| pcap: false | ||
|
|
||
| checks: | ||
| - filter: | ||
| filename: rules.json | ||
| count: 1 | ||
| match: | ||
| flags: | ||
| - src_any | ||
| - dst_any | ||
| - sp_any | ||
| - noalert | ||
| - need_packet | ||
| - toserver | ||
| id: 9901001 | ||
| lists: | ||
| packet: | ||
| matches: | ||
| - name: tcp.flags | ||
| postmatch: | ||
| matches: | ||
| - flowbits: | ||
| cmd: set | ||
| names: | ||
| - tls_tracker | ||
| name: flowbits | ||
| pkt_engines: | ||
| - is_mpm: false | ||
| name: packet | ||
| requirements: | ||
| - tcp_flags_init_deinit | ||
| - real_pkt | ||
| type: pkt | ||
|
|
||
| - filter: | ||
| filename: rules.json | ||
| count: 1 | ||
| match: | ||
| flags: | ||
| - src_any | ||
| - dst_any | ||
| - sp_any | ||
| - need_packet | ||
| - need_stream | ||
| - need_flowvar | ||
| - toserver | ||
| - toclient | ||
| - prefilter | ||
| id: 9901031 | ||
| lists: | ||
| packet: | ||
| matches: | ||
| - flowbits: | ||
| cmd: isset | ||
| names: | ||
| - tls_tracker | ||
| name: flowbits | ||
| payload: | ||
| matches: | ||
| - content: | ||
| depth: 6 | ||
| ends_with: false | ||
| fast_pattern: false | ||
| is_mpm: true | ||
| length: 6 | ||
| negated: false | ||
| no_double_inspect: false | ||
| nocase: false | ||
| pattern: '|15 03 01 00 02 02|' | ||
| relative_next: false | ||
| starts_with: true | ||
| name: content | ||
| postmatch: | ||
| matches: | ||
| - flowbits: | ||
| cmd: set | ||
| names: | ||
| - tls_error | ||
| name: flowbits | ||
| mpm: | ||
| buffer: payload | ||
| depth: 6 | ||
| ends_with: false | ||
| fast_pattern: false | ||
| is_mpm: true | ||
| length: 6 | ||
| negated: false | ||
| no_double_inspect: false | ||
| nocase: false | ||
| pattern: '|15 03 01 00 02 02|' | ||
| relative_next: false | ||
| starts_with: true | ||
| pkt_engines: | ||
| - is_mpm: true | ||
| name: payload | ||
| - is_mpm: false | ||
| name: packet | ||
| requirements: | ||
| - payload | ||
| - flow | ||
| type: pkt_stream | ||
|
|
||
| - filter: | ||
| filename: rules.json | ||
| count: 1 | ||
| match: | ||
| flags: | ||
| - src_any | ||
| - dst_any | ||
| - dp_any | ||
| - need_packet | ||
| - need_stream | ||
| - need_flowvar | ||
| - toserver | ||
| - toclient | ||
| - prefilter | ||
| id: 9901032 | ||
| lists: | ||
| packet: | ||
| matches: | ||
| - flowbits: | ||
| cmd: isset | ||
| names: | ||
| - tls_tracker | ||
| name: flowbits | ||
| payload: | ||
| matches: | ||
| - content: | ||
| depth: 6 | ||
| ends_with: false | ||
| fast_pattern: false | ||
| is_mpm: true | ||
| length: 6 | ||
| negated: false | ||
| no_double_inspect: false | ||
| nocase: false | ||
| pattern: '|15 03 01 00 02 02|' | ||
| relative_next: false | ||
| starts_with: true | ||
| name: content | ||
| postmatch: | ||
| matches: | ||
| - flowbits: | ||
| cmd: set | ||
| names: | ||
| - tls_error | ||
| name: flowbits | ||
| mpm: | ||
| buffer: payload | ||
| depth: 6 | ||
| ends_with: false | ||
| fast_pattern: false | ||
| is_mpm: true | ||
| length: 6 | ||
| negated: false | ||
| no_double_inspect: false | ||
| nocase: false | ||
| pattern: '|15 03 01 00 02 02|' | ||
| relative_next: false | ||
| starts_with: true | ||
| pkt_engines: | ||
| - is_mpm: true | ||
| name: payload | ||
| - is_mpm: false | ||
| name: packet | ||
| requirements: | ||
| - payload | ||
| - flow | ||
| type: pkt_stream | ||
|
|
||
| # Following is the signature of interest | ||
| - filter: | ||
| filename: rules.json | ||
| count: 1 | ||
| match: | ||
| flags: | ||
| - src_any | ||
| - dst_any | ||
| - sp_any | ||
| - need_flowvar | ||
| - toserver | ||
| id: 9901033 | ||
| lists: | ||
| packet: | ||
| matches: | ||
| - flowbits: | ||
| cmd: isset | ||
| names: | ||
| - tls_error | ||
| name: flowbits | ||
| pkt_engines: | ||
| - is_mpm: false | ||
| name: packet | ||
| requirements: | ||
| - flow | ||
| type: pkt | ||
|
|
||
| - filter: | ||
| filename: rules.json | ||
| count: 1 | ||
| match: | ||
| flags: | ||
| - src_any | ||
| - dst_any | ||
| - dp_any | ||
| - need_flowvar | ||
| - toclient | ||
| id: 9901034 | ||
| lists: | ||
| packet: | ||
| matches: | ||
| - flowbits: | ||
| cmd: isset | ||
| names: | ||
| - tls_error | ||
| name: flowbits | ||
| pkt_engines: | ||
| - is_mpm: false | ||
| name: packet | ||
| requirements: | ||
| - flow | ||
| type: pkt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # Test Description | ||
|
|
||
| This test shows that Suricata generates an additional alert for TLS | ||
| for the given PCAP which shouldn't be there. | ||
|
|
||
| ## PCAP | ||
|
|
||
| Internal. | ||
|
|
||
| ## Related issues | ||
|
|
||
| None so far. State: Trying to establish what's the issue. | ||
|
There was a problem hiding this comment. nit: There is a ticket now: https://redmine.openinfosecfoundation.org/issues/7318 |
||
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| alert tcp any any -> any 443 (flow: to_server; flags: S,CE; flowbits:set, tls_tracker; flowbits: noalert; sid:09901001; ) | ||
| alert tcp any any -> any 443 (flowbits:isset, tls_tracker; content: "|15 03 01 00 02 02|"; startswith; flowbits:set, tls_error; sid:09901031; rev:1; msg:"TLS 1.2 Fatal Alert (outgoing packet)"; ) | ||
| alert tcp any 443 -> any any (flowbits:isset, tls_tracker; content: "|15 03 01 00 02 02|"; startswith; flowbits:set, tls_error; sid:09901032; rev:1; msg:"TLS 1.2 Fatal Alert (incoming packet)"; ) | ||
| alert tcp any any -> any 443 (flow: to_server; flowbits:isset, tls_error; sid:09901033; rev:1; msg:"Allow TLS error handling (outgoing packet)"; ) | ||
| alert tcp any 443 -> any any (flow: to_client; flowbits:isset, tls_error; sid:09901034; rev:1; msg:"Allow TLS error handling (incoming packet)"; ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| requires: | ||
| min-version: 8 | ||
|
|
||
| args: | ||
| - -k none | ||
| - --simulate-ips | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 2 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 9901033 | ||
| pkt_src: wire/pcap | ||
| - filter: | ||
| count: 0 | ||
| match: | ||
| event_type: alert | ||
| not-has-key: pcap_cnt |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these checks should be dropped, and test the pkt_src in the first check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can patch it up later