test: add test for vlan.id - v3 #2134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
catenacyber
reviewed
Nov 27, 2024
| @@ -0,0 +1,3 @@ | |||
| alert ip any any -> any any (msg:"Vlan ID is equal to 200 with especific layer"; vlan.id:200,1; sid:1;) | |||
catenacyber
reviewed
Nov 27, 2024
| @@ -0,0 +1,3 @@ | |||
| alert ip any any -> any any (msg:"Vlan ID is equal to 200 with especific layer"; vlan.id:200,1; sid:1;) | |||
| alert ip any any -> any any (msg:"Vlan ID is equal to 300 with explicit 'any' layer "; vlan.id:300,any; sid:2;) | |||
| alert ip any any -> any any (msg:"Vlan ID is equal to 400"; vlan.id:300; sid:3;) | |||
There was a problem hiding this comment.
msg:"Vlan ID is equal to 400"; vlan.id:300;
These do not seem to match...
catenacyber
reviewed
Nov 27, 2024
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 |
There was a problem hiding this comment.
Could we check the vlan id in the alert data ?
There was a problem hiding this comment.
Sorry, I didn't understand the question. Could you be more specific, please?
There was a problem hiding this comment.
Can we we add in this match section a check about vlan.id: 200 ? (with the good syntax and value)
There was a problem hiding this comment.
I don't think so. Should I use these other commits as examples for the implementation?
There was a problem hiding this comment.
schema.json tells me that it should be vlan[0]: 200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1065
Description:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/1065
Suricata PR: OISF/suricata#12103
Previous PR: #2124