tests: linktype_name test #1994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 6954 Ensure that the linktype_name is included in the alerts.
This was referenced Jul 27, 2024
|
Needs to pass on 6.0x and 7.0.x. |
Issue: 4974
This commit extends the linktype_name validation across the existing
tests so that more linktype name values are checked:
- C_HDLC
- PPP
- IPV4
- IPV6
- RAW
- EN10B
- LINUX_SLL
Some existing tests required suricata.yaml configuration to enable the
packet values to be in the alerts.
| @@ -1,6 +1,7 @@ | |||
| requires: | |||
|
|
|||
| min-version: 6.0.0 | |||
| lt-version: 8 | |||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: http |
There was a problem hiding this comment.
is this indentation correct yaml? Looks like 4 spaces instead of 2?
There was a problem hiding this comment.
This was in the original file.
Do you recommend fixing the original in addition to this one?
|
Continued in #1996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1853
Issue: 6954
Ensure that the linktype_name is included in the alerts.
Updates:
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6954
Suricata PR: OISF/suricata#11564