Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/pgsql: update password log disabled msgs - v2 #1514

Conversation

jufajardini
Copy link
Contributor

@jufajardini jufajardini commented Dec 6, 2023

Removing the white spaces from this log output, as these can cause issues with grepping commands querying log results, and also doesn't show a consistent behavior among different environments.

Previous PR: #1511

Following Jason's reflection on why to log the disabled password log output at all, remove checks for those.

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6603

Removing the white spaces from this log output, as these can cause
issues with grepping commands querying log results, and also doesn't
show a consistent behavior among different environments.
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@victorjulien
Copy link
Member

Merged in #1517, thanks!

@jufajardini jufajardini deleted the sv-pgsql-update-password-output/v2 branch December 13, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants