test: test requires keyword - v1 #1505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test with the example rules I shared in the previous PR? |
inashivb
reviewed
Dec 4, 2023
inashivb
reviewed
Dec 4, 2023
jasonish
force-pushed
the
requires-keyword/v1
branch
2 times, most recently
from
547296a to
f598d65
Compare
Done. |
jasonish
force-pushed
the
requires-keyword/v1
branch
from
f598d65 to
547edd4
Compare
jasonish
force-pushed
the
requires-keyword/v1
branch
from
547edd4 to
3f3ef02
Compare
victorjulien
approved these changes
Dec 19, 2023
catenacyber
reviewed
Dec 19, 2023
|
|
||
| # These rules have something invalid about them, but do follow the general rule | ||
| # structure, so should be eliminated by the requires statement. | ||
| alert vxlan any any -> any any (requires: version >= 10; sid:1;) |
There was a problem hiding this comment.
I would put version 42 rather than 10 which is within our lifetimes I hope
catenacyber
reviewed
Dec 19, 2023
| alert http any any -> any any (msg:"TEST Suricata >= 7 and < 8"; content:"uid=0"; requires: version >= 7 < 8; sid:7; rev:1;) | ||
|
|
||
| # Rule for Suricata >= 7.0.3 but less than 8... Or >= 8.0.1 | ||
| alert http any any -> any any (content:"uid=0"; requires: version >= 7.0.3 < 8 | >= 8.0.1; sid:9; rev:1;) |
There was a problem hiding this comment.
Wow we allow complex "or" !
catenacyber
reviewed
Dec 19, 2023
| alert vxlan any any -> any any (requires: version >= 10; sid:1;) | ||
| alert udp any any -> any any (vxlan_vni:10; requires: version >= 10; sid:2;) | ||
| alert http any any => any any (requires: version >= 10; sid:3;) | ||
| alert tcp any any -> any any (frame:smtp.not_supported; requires: version >= 10; sid:4;) |
There was a problem hiding this comment.
Could we also test requires: version >= 10, superpower: notyet ? (superpower being an unknown key yet for the requires keyword
|
Merged in #1558, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes readme update for files to exists as a requirement.