Add test about enip stats with _udp prefix #1504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6304
This was referenced Dec 1, 2023
| @@ -0,0 +1,11 @@ | |||
| # Description | |||
|
|
|||
| Test ENIP stats always have `_udp` or `_tcp` prefix | |||
There was a problem hiding this comment.
I don't see how this is tested?
There was a problem hiding this comment.
Json schema verification
There was a problem hiding this comment.
As CI failure with current master shows
There was a problem hiding this comment.
I expect a check for the stats by name, as that is what the work is about I think
There was a problem hiding this comment.
Right, doing a next iteration.
|
Replaced by #1546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6304
Suricata PR coming