Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sip: add tests for sip over tcp v4 #1499

Closed
wants to merge 1 commit into from

Conversation

glongo
Copy link
Contributor

@glongo glongo commented Nov 28, 2023

Ticket

If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:

Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3351

@glongo
Copy link
Contributor Author

glongo commented Nov 28, 2023

Suricata PR: OISF/suricata#9909

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the changes! Looks good to me :)

@jufajardini jufajardini added the requires suricata pr Depends on a PR in Suricata label Nov 29, 2023
@victorjulien victorjulien self-requested a review December 2, 2023 14:39
Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be updated to pass on 6 and 7, only on 8 it can fail but should pass with the Suricata PR.

@glongo
Copy link
Contributor Author

glongo commented Dec 4, 2023

Are the following changes acceptable? (It's only one test as an example.)

cc @jufajardini

--- a/tests/sip-tcp-method/test.yaml
+++ b/tests/sip-tcp-method/test.yaml
@@ -1,5 +1,5 @@
 requires:
-  min-version: 8
+  min-version: 6
 
 args:
   - -k none
@@ -9,15 +9,18 @@ pcap: sip-tcp.pcap
 
 checks:
   - filter:
+      min-version: 8
       count: 1
       match:
         event_type: alert
   - filter:
+      min-version: 8
       count: 2
       match:
         proto: TCP
         event_type: sip
   - filter:
+      min-version: 8
       count: 1
       match:
         event_type: stats

@victorjulien
Copy link
Member

Yeah I think that should be fine.

@glongo glongo closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires suricata pr Depends on a PR in Suricata
Development

Successfully merging this pull request may close these issues.

3 participants