http2: check for http_response_line exact content #1491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
added
requires suricata pr
This was referenced Nov 23, 2023
|
This will fail both 7 and 8 until PR and its backport get merged |
|
Can you force push a update to limit this PR to 8 at first? |
Ticket: 6547
catenacyber
force-pushed
the
http2-response_line-6547-v1
branch
from
a97129b to
9158a56
Compare
Trying something... Was not the label |
Not yet, right now I run it manually and it's not yet aware of flags here. |
victorjulien
approved these changes
Dec 12, 2023
|
Merged in #1541, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6547