ssh: do not test direction #1490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2023
as we log packet direction instead of flow direction
catenacyber
force-pushed
the
output-alert-applayer-v5
branch
from
b30d6f5 to
bbc4d46
Compare
This was referenced Jan 16, 2024
Closed
|
Closing as unwanted cf OISF/suricata#10300 (comment) |
Also, we probably shouldn't remove the direction. But make sure the direction is tested, and is how it should be. Then fix Suricata to match. We need a full check of proto directions for 8 IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we log packet direction instead of flow direction
Ticket
Redmine ticket: should there be one ?