Adds test about mime when stream depth is reached #1390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inashivb
reviewed
Sep 21, 2023
| @@ -0,0 +1,8 @@ | |||
| # Description | |||
|
|
|||
| Test mime base64 decoding completeness when stream depth is reached | |||
There was a problem hiding this comment.
Is this on the standard stream depth setting for now? 64 mb?
While I see that we're not trying to store any files, would filestore's stream depth settings also affect this (as it should ideally override stream's depth settings)?
So, should we have a suricata.yaml in this test? Or would we never change the standard settings for depths? wdyt?
There was a problem hiding this comment.
Yes, it is for standard depth which is 1Mb
would filestore's stream depth settings also affect this (as it should ideally override stream's depth settings)?
Maybe
So, should we have a suricata.yaml in this test?
Yes, or --set stream.depth=1mb
There was a problem hiding this comment.
stream.reassembly.depth in facts
|
Continued in #1393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6367
Suricata PR incoming