tests: deduplicate pcaps, cleanup extras - v3

[jufajardini]

Previous PR: #1352

Change from previous PR:

• change pcap reference in geoip test, as the pcap it was linking to is now also using a reference (cf tests: deduplicate pcaps, cleanup extras #1352 (comment))

[inashivb]

LGTM. Thanks for picking this up! :)

[jufajardini]

LGTM. Thanks for picking this up! :)

🙇🏽 Team work! ^^

[victorjulien]

No longer passes on master-6.0.x

[victorjulien]

Fails on some of my builders

===> exception-policy-stream-reassembly-memcap-08: FAILED: got exit code 1, expected 0
===> exception-policy-stream-reassembly-memcap-09: FAILED: got exit code 1, expected 0
===> exception-policy-stream-reassembly-memcap-07: FAILED: got exit code 1, expected 0

[jasonish]

Would it make sense to have some pre-merge process, perhaps even parse of createst that renames any new pcaps to a filename based on its hash and dumps the file in pcaps/. Test could then reference the pcap by hash?

[jasonish]

Continue at #1401.

[inashivb]

Would it make sense to have some pre-merge process, perhaps even parse of createst that renames any new pcaps to a filename based on its hash and dumps the file in pcaps/. Test could then reference the pcap by hash?

That's genius! I'm thinking why didn't i think of this before. 😅
A standard pcap location would also make the script I use to find the duplicates and change the pcap fields much much easier.

Could there be any drawbacks?

[inashivb]

Merged in #1402. Thanks! :)