Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add tests for smb.version keyword v2 #1379

Closed

Conversation

jmtaylor90
Copy link
Contributor

Ticket

If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:

Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5075

@jmtaylor90
Copy link
Contributor Author

  • Added pcap origination information
  • Included original author commits (was suggested in the code review for the smb.version code)

@jmtaylor90 jmtaylor90 closed this Sep 6, 2023
@jmtaylor90 jmtaylor90 deleted the smb-version-keyword-tests-v2 branch September 6, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants