-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: Add a single version number with commit process #5746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ohif-dev canceled.
|
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/single-commit-with-version
|
| Run status |
|
| Run duration | 02m 50s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
37
|
| View all changes introduced in this branch ↗︎ | |
jbocce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with the changes, but I wonder why it was done in two commit before. Also, I am not sure if right near release we want to do this change. Sounds like something to do going forward in 3.13. Just my two cents. Please wait for Alireza's review prior to merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the release commit process to create a single commit instead of two, with the version number included in the commit message. The changes modify the git workflow in the publish-version script to stage all changes before running lerna, then amend lerna's commit to include all files in one unified commit.
Changes:
- Added
.trim()to version reading for safer string handling - Restructured git workflow to stage changes before lerna runs (instead of committing them separately)
- Added
--no-pushflag to lerna to prevent automatic pushing - Implemented commit amending to combine version.json and package.json updates into a single commit
- Changed push strategy to use
--force-with-leasedue to the amended commit
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Context
Changes the commit message on release to main to be a single commit rather than two, and include the version number in the message.
No functional change.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment