Skip to content

Conversation

@wayfarer3130
Copy link
Contributor

Context

Changes the commit message on release to main to be a single commit rather than two, and include the version number in the message.

No functional change.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@wayfarer3130 wayfarer3130 requested a review from sedghi January 27, 2026 15:35
@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit cf625e9
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6979074761d4da000859c93d

@cypress
Copy link

cypress bot commented Jan 27, 2026

Viewers    Run #5890

Run Properties:  status check passed Passed #5890  •  git commit cf625e9c96: PR review comments
Project Viewers
Branch Review fix/single-commit-with-version
Run status status check passed Passed #5890
Run duration 02m 50s
Commit git commit cf625e9c96: PR review comments
Committer Bill Wallace
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 37
View all changes introduced in this branch ↗︎

Copy link
Collaborator

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the changes, but I wonder why it was done in two commit before. Also, I am not sure if right near release we want to do this change. Sounds like something to do going forward in 3.13. Just my two cents. Please wait for Alireza's review prior to merging.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the release commit process to create a single commit instead of two, with the version number included in the commit message. The changes modify the git workflow in the publish-version script to stage all changes before running lerna, then amend lerna's commit to include all files in one unified commit.

Changes:

  • Added .trim() to version reading for safer string handling
  • Restructured git workflow to stage changes before lerna runs (instead of committing them separately)
  • Added --no-push flag to lerna to prevent automatic pushing
  • Implemented commit amending to combine version.json and package.json updates into a single commit
  • Changed push strategy to use --force-with-lease due to the amended commit

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants