Added the Korean (kr) language support #2470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2470 +/- ##
=======================================
Coverage 13.33% 13.33%
=======================================
Files 288 288
Lines 7664 7664
Branches 1465 1465
=======================================
Hits 1022 1022
Misses 5378 5378
Partials 1264 1264 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I'm not familiar with the Korean language, but in Locize ko-KR seems to be the only option. Is this the same as kr that you have used?
We use Locize to maintain the translations. You can read more here.
Can you change your PR according to ko-KR, since all files will get overwritten by Locize ...
| @@ -41,6 +41,13 @@ module.exports = (env, argv) => { | |||
| path: DIST_DIR, | |||
| filename: isProdBuild ? '[name].bundle.[chunkhash].js' : '[name].js', | |||
| publicPath: PUBLIC_URL, // Used by HtmlWebPackPlugin for asset prefix | |||
| devtoolModuleFilenameTemplate: function(info) { | |||
| @@ -29,7 +29,7 @@ import OHIFDicomSegmentationExtension from '@ohif/extension-dicom-segmentation'; | |||
| import OHIFDicomRtExtension from '@ohif/extension-dicom-rt'; | |||
| import OHIFDicomMicroscopyExtension from '@ohif/extension-dicom-microscopy'; | |||
| import OHIFDicomPDFExtension from '@ohif/extension-dicom-pdf'; | |||
| //import OHIFDicomTagBrowserExtension from '@ohif/extension-dicom-tag-browser'; | |||
| import OHIFDicomTagBrowserExtension from '@ohif/extension-dicom-tag-browser'; | |||
There was a problem hiding this comment.
please limit this PR to be only for translation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
base has changed, read more here #3477 |
Hi team,
Thank you for all your efforts for implementing this create viewer.
I want to add the the Korean locales to the viewer.
If you prefer letting me to work on the Locize, you can create the space for the Korean language and let me know too.
Thank you in advance for your support.