Overlay: ProfileSessionListener - fix crash in finializeSession

OGRECave · Jan 7, 2024 · 7548e05 · 7548e05
1 parent ee5fd3b
commit 7548e05
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/Components/Overlay/src/OgreOverlayProfileSessionListener.cpp b/Components/Overlay/src/OgreOverlayProfileSessionListener.cpp
@@ -110,11 +110,10 @@ namespace Ogre
         OverlayContainer* container = dynamic_cast<OverlayContainer*>(mProfileGui);
         if (container)
         {
-            for (const auto& p : container->getChildren())
+            while (!container->getChildren().empty())
             {
-                OverlayElement* element = p.second;
-                OverlayContainer* parent = element->getParent();
-                if (parent) parent->removeChild(element->getName());
+                OverlayElement* element = container->getChildren().cbegin()->second;
+                container->removeChild(element->getName());
                 OverlayManager::getSingleton().destroyOverlayElement(element);
             }
         }