Cleanup trainer and SmartSimMeshMotionSolver #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashao
commented
Oct 8, 2025
ashao
commented
- Separates out the training/definition of the model from the training script
- Modifies the SmartSimMeshMotionSolver to only post the boundary points on initialization because they are static in time.
Adjust the loss function to weight by the distance from the
"center" of the ellipsoid by an exponent d (e.g. r^{d}).
Additionally, reduce the default size of the MLP to avoid having
an overdetermined system (# of free parameters > samples).
Modify the solve routine and add a new method called during the, meshMotion constructor so that the boundary points are only posted once.
Break the definition and particulars of model training out of the training script into their own files. To include a new model, users should add another file to networks directory and create two new classes: the model class which defines the architecture and the trainer class which controls how the model is trained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.