Fix SQLite Result ValueDateTime data-type regression bug #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@aufdenkampe and @horsburgh This PR fixes the SQLite regression bug described in #158. I usually prefer to have someone else review changes; let me know if you can do it this week, otherwise I'll go ahead and merge on Friday (we'll see also how the CI checks do -- they should be fine). FYI, this PR involves a change to just one line. This is one of the two must-do elements in my targets for the new release (#165). |
Fixed a set of 40 TimeSeriesResultValues insert statements in the populated.sql test SQLite database creation file, where the datetimes where only specified as dates, not datetimes. That was leading to the use of a non-datetime field type. Also changed odm2api module path calls in test_odm2/test_readservice.py to remove deprecated use of ODM2 module hierarchy.
Member
Author
|
Closing. Discovered that bug was related to messy (bad) datetime strings in the tests/test_odm2/data/populated.sql test SQLite database ddl. Fixing that file, then submitting new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158.
Tested on the timeseries notebook at https://github.com/ODM2/ODM2PythonAPI/blob/master/Examples/TimeSeries_RetrieveVisualize.ipynb