Always print tests output relative to import/gnucobol/ #28
Conversation
| let rec iter path = | ||
| match path with | ||
| | [] -> s | ||
| | "import" :: "gnucobol" :: _ -> String.concat "/" path |
There was a problem hiding this comment.
While you're at it, why not strip the import altogether?
Also ppf stands for pretty-printing-formatter (I think). fmt is the old-school name, that unfortunately can be mistaken for "format(-string)".
There was a problem hiding this comment.
Ok for ppf. For import, I don't want to match only on gnucobol, as it may appear above the source directory...
lefessan
force-pushed
the
z-2023-09-28-rebase-Considering
branch
from
904c45c
to
0483385
Compare
SuperBOL includes superbol-studio-oss as a sub-module, so we have to make our tests as "relocatable" as possible.
lefessan
force-pushed
the
z-2023-09-28-rebase-Considering
branch
from
0483385
to
2b9c53e
Compare
| @@ -401,10 +401,10 @@ let%expect_test "formatting-request-whole-program" = | |||
| end_with_postproc [%expect.output]; | |||
| [%expect {| | |||
| {"params":{"diagnostics":[],"uri":"file://__rootdir__/superbol.toml"},"method":"textDocument/publishDiagnostics","jsonrpc":"2.0"} | |||
| src/lsp/cobol_ast/raw_misc_sections_visitor.ml:66: | |||
| raw_misc_sections_visitor.ml:0: | |||
There was a problem hiding this comment.
@lefessan What was the problem of having precise source locations here?
To me the occasional need for an auto-promotion does not warrant the ugly hack used in this PR to remove the info.
There was a problem hiding this comment.
These locations are very handy when implementing the partial visitors, even and in particular in the tests.
No description provided.