improve user-defined config file detection #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The idea behind this PR is to change the way the global user-defined configuration file path is chosen, to make it more standard and to follow the suitable conventions on all platforms. I used directories.
With this PR, the path is computed as follow:
$XDG_CONFIG_HOME/ocp-indent/config
with$XDG_CONFIG_HOME
defaulting to$HOME/.config/
$HOME/Library/Application Support/com.OCamlPro.ocp-indent/config
{FOLDERID_ApplicationData}/OCamlPro/ocp-indent/config
; the path of{FOLDERID_ApplicationData}
can be obtained only using SHGetKnownFolderPathdirectories
has no dependency, except on Windows where it depends onctypes
, it works on all OCaml version from4.07
, but I haven't tested older versions.