Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (small) PR allows the COB_CC variable to contain spaces, by adding quotes to any
sprintf
that use it.Otherwise, one would need to escape all the spaces in COB_CC, and while this is acceptable "in general", this is slightly inconvenient, and besides the other variables do not work this way (for instance try escaping spaces in COB_CONFIG_DIR and you'll see it fails finding the config files - if the path contains spaces).
This of course works as long as COB_CC only contains the path to the C compiler and no argument - which should be the case since arguments should go in COB_CFLAGS & friends.
This would also allow us to get rid of the
gcobc
wrapper we have in our Windows installer (cf. your comment: "I'd like to know what "gcobc" is"), whose sole purpose is to callcobc
with a space-escaped COB_CC.EDIT: probably needs more work, considering the failures on Windows (had only tested on Linux so far)