Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using drom at minimal version by default + Update version #14

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Avoid using drom at minimal version by default + Update version #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc17b2f
Removed the default minimal `drom` version in templates.
Jul 24, 2024
0d9f660
Updated versionning constraints.
Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DROM_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
0.9.2~dev3
0.9.3~dev

3 changes: 2 additions & 1 deletion LATEST_VERSIONS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# all versions >= 0.9.2~dev should use 0.9.2
dev 0.9.2
dev 0.9.3
0.9.3~dev 0.9.3
# all version < 0.9.2~dev should use 0.9.2
0.9.2~dev 0.9.2
0.9.0~dev 0.9.1
Expand Down
3 changes: 1 addition & 2 deletions projects/virtual/drom.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[project]
drom-version = "0.1.0"
# drom-version = "0.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a doubt, does it mean that the drom-version is not specified, or the version of drom is added as drom-version in the drom.toml file ? I think it is important that a value is always written, but I don't really care which version is chosen by default.

Actually, there is also the idea that there is a phase of creation of the project, during which these files are modified by the project creator (and all other files are updated), while when the creation phase is over, only a minimal set of files are updated. We could decide that ending the creation phase requires setting the drom-version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the corresponding drom, if no drom-version is given, drom will use its current version.

As for the creation phase, I dont' know... Personally, I always have to change drom stuff during a project lifetime so I don't really see a "creation phase". drom should simplifies the programmer's life, not complicate it with more (possibly non standard) processes.


[project]
authors = [!{authors-for-toml}]
Expand Down Expand Up @@ -46,4 +46,3 @@ for-test = true
[project]
pack-modules = true
skip-dirs = []