Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, it seems the model generation for records didn't work on
next
. The reason is simple. If we want to produce a value for a declared record, we need to accumulate all the accesses to this record. For instance, the following input file:didn't produce a correct model. It assigned
0
for any field of typeInt
.Note: for functional arrays, we can use the
ModelMap.t
structure to accumulate thestore
instructions as functional arrays can be seen as a map. We cannot do the same thing for records since each destructor of the record can return a different type.