Rebase of Optim Alt-Ergo #553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Halbaroth
force-pushed
the
rebase-optim-alt
branch
2 times, most recently
from
6d9f549 to
afe84b6
Compare
… instead of valid as a result
…ds to be well understood before making it work for every case
…int model and interpretation
…mmy fresh value when no value is computed
Useful when/if the SAT don't see/assign internal bool expression and/or SAT assignement is not propagated to theories (eg. because of CDCL(Tableaux) filtering)
all_models: reset last saved model before exploring other branches all_models: re-set timelimit, which is inteded to be used per SAT branch/model in this case print_status: Unknown instead of Timeout if get_interpretation && why3 output continue models enumeration after a Timeout avoid infinite loop in case no progression is made in all-models enumeration do not support check-all-sat/all-models in Fun_SAT add missing cases to GUI
Formulas are only processed once SAT.unsat is called, old behavior can be enforced with option --process-when-assuming
This was referenced Jun 8, 2023
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 23, 2023
This is a new version of OCamlPro#679, which itself was a new version of OCamlPro#472. A similar fix is also in OCamlPro#553 as bb55438 The crux of it is that the bitvector theory returns *interpreted* values as leaves, where the rest of the solver requires leaves to be *uninterpreted terms*. The main difference of this patch with the other patches above is that here we only create the fresh terms associated with variables *after* solving, so we only create fresh terms that we do expose. On the other hand, the solver may create many variables internally that gets split or otherwise merged and whose associated terms would never get used. Fixes OCamlPro#350 Fixes OCamlPro#664
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 23, 2023
This is a new version of OCamlPro#679, which itself was a new version of OCamlPro#472. A similar fix is also in OCamlPro#553 as bb55438 The crux of it is that the bitvector theory returns *interpreted* values as leaves, where the rest of the solver requires leaves to be *uninterpreted terms*. The main difference of this patch with the other patches above is that here we only create the fresh terms associated with variables *after* solving, so we only create fresh terms that we do expose. On the other hand, the solver may create many variables internally that gets split or otherwise merged and whose associated terms would never get used. Fixes OCamlPro#350 Fixes OCamlPro#664
bclement-ocp
added a commit
that referenced
this pull request
Jun 23, 2023
This is a new version of #679, which itself was a new version of #472. A similar fix is also in #553 as bb55438 The crux of it is that the bitvector theory returns *interpreted* values as leaves, where the rest of the solver requires leaves to be *uninterpreted terms*. The main difference of this patch with the other patches above is that here we only create the fresh terms associated with variables *after* solving, so we only create fresh terms that we do expose. On the other hand, the solver may create many variables internally that gets split or otherwise merged and whose associated terms would never get used. Fixes #350 Fixes #664
|
Should we close this in favor of #776? |
|
Yes we should! I thought I did it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.