Fix issue 1212 #1269
Merged
Fix issue 1212 #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During model extraction, we only should store accesses to arrays whose the representative elements are names. Indeed, if the representative is not a name, this array cannot appear in a model. The embedded case is correctly managed because we generate fresh names that will become the representative elements.
hra687261
approved these changes
Jan 27, 2025
bclement-ocp
previously requested changes
Jan 27, 2025
There was a problem hiding this comment.
I had the above comment marked as pending for a while (sorry! GitHub UI strikes again). I think this is still the case -- can you add a comment in the file so that we don't later think that we break things when we fix #929?
Comment on lines
+2
to
+6
| unknown | ||
| ( | ||
| (define-fun a () (Array Int Int) (as @a3 (Array Int Int))) | ||
| (define-fun b () (Array Int Int) (as @a2 (Array Int Int))) | ||
| ) |
bclement-ocp
dismissed
their stale review
OK to merge with a comment in 1212.default.smt2; did not intend to block things.
|
Sorry, I didn't follow notifications on Alt-Ergo for a long time. I will fix it and merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During model extraction, we only should store accesses to arrays whose the representative elements are names. Indeed, if the representative is not a name, this array cannot appear in a model.
The embedded case is correctly managed because we generate fresh names that will become the representative elements.