Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDX-10569 - Set canonical for derived individual dataset / org / loca… #6555

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

HDX-10569 - Set canonical for derived individual dataset / org / loca… #6555

wants to merge 2 commits into from

Conversation

aalecs
Copy link
Member

@aalecs aalecs commented Mar 19, 2025

…tion pages

  • org + custom org page implement canonical for extra params or url that uses id in place of name
  • change snippet to auto check base url id vs name
  • package refactor a bit
  • country + custom country page + org list - canonical only for extra params
  • events + dashboard - extra + id vs name
  • light page (events & dashboard) - fix trailing "/" in url messing up canonical structure
  • extract the selected category keys in the search page
  • refactor snippet to be able to exclude certain path params (whitelisted ones, used for search page)
  • fix light dataset trailing "/" in URL
  • add canonical in search page, allowing for filter item generated "sub-pages"
  • refactor snippet to support mobile pages as well
  • update mobile pages to new snippet + testing
  • fix dataset pagination creating urls like "/dataset/?page=3"

@aalecs
HDX-10569 - Set canonical for derived individual dataset / org / loca…
ac450c8 
…tion pages

 - org + custom org page implement canonical for extra params or url that uses id in place of name
 - change snippet to auto check base url id vs name
 - package refactor a bit
 - country + custom country page + org list - canonical only for extra params
 - events + dashboard - extra + id vs name
 - light page (events & dashboard) - fix trailing "/" in url messing up canonical structure
 - extract the selected category keys in the search page
 - refactor snippet to be able to exclude certain path params (whitelisted ones, used for search page)
 - fix light dataset trailing "/" in URL
 - add canonical in search page, allowing for filter item generated "sub-pages"
 - refactor snippet to support mobile pages as well
 - update mobile pages to new snippet + testing
 - fix dataset pagination creating urls like "/dataset/?page=3"
@aalecs aalecs requested a review from alexandru-m-g March 19, 2025 16:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build #6199

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 4 files are covered.
  • 115 unchanged lines in 6 files lost coverage.
  • Overall coverage remained the same at 75.083%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext-hdx_search/ckanext/hdx_search/controller_logic/search_logic.py 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
ckanext-hdx_package/ckanext/hdx_package/views/contribute_flow.py 3 74.32%
ckanext-hdx_theme/ckanext/hdx_theme/plugin.py 5 87.5%
ckanext-hdx_package/ckanext/hdx_package/helpers/helpers.py 10 60.55%
ckanext-hdx_package/ckanext/hdx_package/helpers/custom_validator.py 30 85.42%
ckanext-hdx_package/ckanext/hdx_package/views/dataset.py 31 82.89%
ckanext-hdx_package/ckanext/hdx_package/plugin.py 36 71.48%
Totals Coverage Status
Change from base Build #6192: 0.0%
Covered Lines: 12623
Relevant Lines: 16812
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandru-m-g alexandru-m-g alexandru-m-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalecs @coveralls @alexandru-m-g