-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[17.0][MIG] web_m2x_options_manager #3360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] web_m2x_options_manager #3360
Conversation
…ons from interface
Currently translated at 76.4% (26 of 34 strings) Translation: web-14.0/web-14.0-web_m2x_options_manager Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-14.0/web-14.0-web_m2x_options_manager Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-14.0/web-14.0-web_m2x_options_manager Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager/
Currently translated at 100.0% (33 of 33 strings) Translation: web-14.0/web-14.0-web_m2x_options_manager Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager/it/
7d49d19 to
bb9e666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @SilvioC2C
Migration commit is rather a big commit that introduces new features/improvements.
Can you probably split this commit to several starting from the migration one and other?
Many many thanks for this beautiful module!
|
Hello @yankinmax, I would rather not: it wouldn't make sense to do a "bare" migration of a module that doesn't exist yet on v17 (meaning: do the bare minimum to have it installed on a v17 instance), just to do a major overhaul in the commit right after that. |
Camille0907
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Field ``option_create_edit_wizard`` has been dropped in the migration: the pop-up wizard does not exist anymore, so the field has no use
bb9e666 to
d8e3e57
Compare
| # OVERRIDE: allow searching by field tech name if the correct context key is | ||
| # used; in this case, fields fetched by tech name are prepended to other fields | ||
| result = super().name_search(name, args, operator, limit) | ||
| if not (name and self.env.context.get("search_by_technical_name")): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always prefer self.env.context.get("search_by_technical_name", False) not to have None, but it's a matter of taste of course
yankinmax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
|
This PR has the |
|
@OCA/web-maintainers ping please? 🙏 |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 0f77378. Thanks a lot for contributing to OCA. ❤️ |
Migration starts from v14, since v15 and v16 modules were not up-to-date.
It also includes fix from #3354 and overhaul from #3357.
Option
m2o_dialogdoes not exist anymore, so its related field on modelm2x.create.edit.optionhas been removed.