Skip to content

Conversation

@SilvioC2C
Copy link
Contributor

@SilvioC2C SilvioC2C commented Nov 10, 2025

⚠️

Migration starts from v14, since v15 and v16 modules were not up-to-date.
It also includes fix from #3354 and overhaul from #3357.
Option m2o_dialog does not exist anymore, so its related field on model m2x.create.edit.option has been removed.

SilvioC2C and others added 18 commits November 6, 2025 12:10
Currently translated at 76.4% (26 of 34 strings)

Translation: web-14.0/web-14.0-web_m2x_options_manager
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-14.0/web-14.0-web_m2x_options_manager
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-14.0/web-14.0-web_m2x_options_manager
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager/
Currently translated at 100.0% (33 of 33 strings)

Translation: web-14.0/web-14.0-web_m2x_options_manager
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_m2x_options_manager/it/
@SilvioC2C SilvioC2C force-pushed the 17.0-mig-web_m2x_options_manager branch 3 times, most recently from 7d49d19 to bb9e666 Compare November 10, 2025 19:01
Copy link
Contributor

@yankinmax yankinmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @SilvioC2C
Migration commit is rather a big commit that introduces new features/improvements.
Can you probably split this commit to several starting from the migration one and other?
Many many thanks for this beautiful module!

@SilvioC2C
Copy link
Contributor Author

Hello @yankinmax, I would rather not: it wouldn't make sense to do a "bare" migration of a module that doesn't exist yet on v17 (meaning: do the bare minimum to have it installed on a v17 instance), just to do a major overhaul in the commit right after that.

Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Field ``option_create_edit_wizard`` has been dropped in the migration: the pop-up wizard does not exist anymore, so the field has no use
@SilvioC2C SilvioC2C force-pushed the 17.0-mig-web_m2x_options_manager branch from bb9e666 to d8e3e57 Compare November 13, 2025 09:48
@SilvioC2C SilvioC2C requested a review from yankinmax November 13, 2025 10:33
# OVERRIDE: allow searching by field tech name if the correct context key is
# used; in this case, fields fetched by tech name are prepended to other fields
result = super().name_search(name, args, operator, limit)
if not (name and self.env.context.get("search_by_technical_name")):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always prefer self.env.context.get("search_by_technical_name", False) not to have None, but it's a matter of taste of course

Copy link
Contributor

@yankinmax yankinmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@SilvioC2C
Copy link
Contributor Author

@OCA/web-maintainers ping please? 🙏

@tarteo
Copy link
Member

tarteo commented Nov 18, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-3360-by-tarteo-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0f77378. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 772e78f into OCA:17.0 Nov 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.