[19.0][MIG] web_search_with_and: Migration to 19.0 #3352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add README.rst Too short underline for module title in README.rst Improving module meta information Version 1.0 W391 blank line at end of file Remove module description because README.rst is there web_search_with_and: Latest OCA conventions
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_search_with_and Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_search_with_and/
|
LGTM, Functional Test OK |
Contributor
|
Hi, really appreciate your migration PR. After testing, the feature works great, only one minor thing I think you need to re-check. The input dropdown does not totally disappear after I press Enter. 
I think you can put this line of code to close the input dropdown. I'm not sure if it's the right way to handle it. But you can take it into account. 
|
lef-adhoc
force-pushed
the
19.0-mig-web_search_with_and
branch
from
b671ccb to
90a7413
Compare
Contributor
Author
|
@Vang-NguyenPhu Thank you very much, that's all sorted! |
Vang-NguyenPhu
approved these changes
Nov 24, 2025
Contributor
Vang-NguyenPhu
left a comment
Vang-NguyenPhu
left a comment
There was a problem hiding this comment.
Functional test & code LGTM
Contributor
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.