Skip to content

Conversation

@BhaveshHeliconia
Copy link
Contributor

@BhaveshHeliconia BhaveshHeliconia commented Oct 14, 2025

When i set system parameter web_dialog_size.default_maximize = True and open the export wizard i found this below bug where wizard is getting shrink automatically which is not a good user experience so i have fixed the issue and made the PR for it.

Screencast.from.2025-10-14.17-48-42.webm.mp4

@BhaveshHeliconia BhaveshHeliconia deleted the 16.0-mig-web_dialog_size branch October 15, 2025 03:50
@BhaveshHeliconia BhaveshHeliconia restored the 16.0-mig-web_dialog_size branch October 15, 2025 03:50
@BhaveshHeliconia BhaveshHeliconia changed the title [FIX] web: prevent export wizard from shrinking when dialog maximize is enabled [FIX] web_dialog_size: prevent export wizard from shrinking when dialog maximize is enabled Oct 15, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 16.0-mig-web_dialog_size branch from c6a74eb to 8096967 Compare October 15, 2025 03:52
@BhaveshHeliconia
Copy link
Contributor Author

ping @pedrobaeza @CarlosRoca13 @DavidJForgeFlow for the reviews. Thanks in advance.

@BhaveshHeliconia BhaveshHeliconia changed the title [FIX] web_dialog_size: prevent export wizard from shrinking when dialog maximize is enabled [16.0][FIX] web_dialog_size: prevent export wizard from shrinking when dialog maximize is enabled Oct 15, 2025
@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 15, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working. Thanks for the patch.

Copy link
Contributor

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍 Code also LGTM!

@pedrobaeza
Copy link
Member

/ocabot merge patch

Please fw-port it to upper versions if applicable.

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3315-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 13ed87b into OCA:16.0 Oct 15, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a939bf3. Thanks a lot for contributing to OCA. ❤️

@BhaveshHeliconia
Copy link
Contributor Author

Please fw-port it to upper versions if applicable.

Yes, forward ports are done — see PRs #3318 and #3319. The module has also been migrated to 19.0 #3320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants