Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] web_refresher: Migration to 18.0 #3001

Open
wants to merge 52 commits into
base: 18.0
Choose a base branch
from

Conversation

achulii
Copy link

@achulii achulii commented Nov 25, 2024

No description provided.

josueBulle and others added 30 commits November 25, 2024 19:28
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/
Currently translated at 100.0% (2 of 2 strings)

Translation: web-16.0/web-16.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/hr/
weblate and others added 18 commits November 25, 2024 19:28
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/
Currently translated at 50.0% (1 of 2 strings)

Translation: web-16.0/web-16.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-17.0/web-17.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_refresher/
Currently translated at 100.0% (2 of 2 strings)

Translation: web-17.0/web-17.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_refresher/it/
Currently translated at 100.0% (2 of 2 strings)

Translation: web-17.0/web-17.0-web_refresher
Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_refresher/es/
… the main

By doing this, the extension view is charged just after the main, so
if some other views are using this other, to make a primary one,
like project is doing for project.task control_panel, the refresher
will continue be shown.
@achulii achulii mentioned this pull request Nov 25, 2024
26 tasks
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migrating this usefull module.

Functional review. LGTM.

Please could you fix pre-commit errors ?

Thanks !

@achulii achulii force-pushed the 18.0-mig-web_refresher branch from db2ee2e to 2688fe2 Compare November 26, 2024 10:35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in a general commit to the repo IMO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why it's needed? If it's something required, it should be reflected on the template.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why it's needed? If it's something required, it should be reflected on the template.

This was done to remove pre-commit errors such as “setTimeout” is undefined. Can you please clarify about the template?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template is in https://github.com/OCA/oca-addons-repo-template/ (through copier)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @achulii, do you have any updates on this?

@LuvForAirplanes
Copy link

Is there any particular reason this isn't yet merged?

@chienandalu
Copy link
Member

Hi @LuvForAirplanes . There comments pending to be attended. It's just a formal question but an easy one to address...

BT-fgarbely added a commit to brain-tec/web that referenced this pull request Jan 13, 2025
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BT-fgarbely
Copy link
Contributor

Hello @achulii

Do you know the state here?
It would be great if we could use this module soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.