Skip to content

[IMP] web_environment_ribbon: hide the ribbon on hover, #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Jun 18, 2024

Hi all.
First thanks for this great module. this trivial PR improve the UI. on hover of the ribbon, the ribbon should be hidden to let user see more easily, the elements that are behind the ribbon.

Thanks for your review !

Note: This PR is in draft state because I don't figure out how to achive the following things :

  • make ribbon invisible when the mouse is hover the ribbon
  • make items under the ribbon clickable.

-> removing point-events:none make items not clickable.
-> Let point-events:none disable .test-ribbon:hover

…ccess and see more easily elements hidden by the ribbon
@pedrobaeza
Copy link
Member

Isn't already hidden when you hover on (which by the way I don't like at all)? Please put the before and after

@legalsylvain
Copy link
Contributor Author

thanks for your review !

Isn't already hidden when you hover on (which by the way I don't like at all)

No, for the time being, the ribbon is hidden on nav and header hover.

Please put the before and after

? didn't understood your point. could you elaborate ?

@pedrobaeza
Copy link
Member

I ask for seeing visually the improvement you are doing.

@legalsylvain legalsylvain marked this pull request as draft June 18, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants