Skip to content

[16.0] [IMP] web_responsive showing main menu when no application is selected #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented May 6, 2024

See

menu

@OCA-git-bot
Copy link
Contributor

Hi @Tardo, @SplashS,
some modules you are maintaining are being modified, check this out!

@eLBati eLBati force-pushed the 16.0-imp-web_responsive branch from 5640a42 to 86975f6 Compare May 6, 2024 12:47
@Tardo
Copy link
Member

Tardo commented May 7, 2024

Code OK. But idk how to "solve" the tests...

@eLBati eLBati marked this pull request as draft May 7, 2024 15:18
@eLBati eLBati force-pushed the 16.0-imp-web_responsive branch from 86975f6 to d5753de Compare May 7, 2024 16:12
@eLBati eLBati marked this pull request as ready for review May 7, 2024 16:13
Copy link

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functional review on runboat

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be something optional.

@eLBati
Copy link
Member Author

eLBati commented May 24, 2024

Hi @pedrobaeza , what problem do you see in setting this as default behavior o the module?
Thanks!

@pedrobaeza
Copy link
Member

For several reasons:

If you assure that there are no problems with points 2 and 3, then 1 can be ignored.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 11, 2024
@primes2h
Copy link

Thanks @eLBati.
Whether it is optional or not, I consider this a must have feature.

@primes2h
Copy link

primes2h commented Oct 25, 2024

* A lot of users have an initial action set. How does this combine with that?

It works well with home action.

home_action

* There are modules like https://github.com/OCA/server-ux/tree/16.0/announcement that shows popups on login that will conflict.

It works well with announcements too.

announcements

@primes2h
Copy link

@eLBati

I would hide the top left button after login.

web_responsive

@eLBati eLBati force-pushed the 16.0-imp-web_responsive branch from d5753de to 0907812 Compare May 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants