[16.0][IMP] web_remember_tree_column_width: adjust SCSS selector #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @luisg123v, @frahikLV, |
cuongnmtm
force-pushed
the
imp-web_remember_tree_column_width-scss-selector
branch
from
6f25175 to
cce3461
Compare
cuongnmtm
changed the title
|
@cuongnmtm It works! |
AurelijaNorvaisaite
approved these changes
Jan 29, 2024
|
Hello @pedrobaeza, could you help with an extra review and possible merge? |
|
Sorry, I don't use this module. |
|
Guys @luisg123v, @frahikLV , can you check it out? |
luisg123v
suggested changes
May 8, 2024
Previously, only columns with the class o_column_sortable had the custom SCSS applied to them. As a result, columns like HTML were not sortable and didn't benefit from the custom SCSS. This commit made changes to the SCSS selector to include all table's columns in the list view. However, the record selector (the first checkbox column) and the column optional (the last column) that have the class o_list_controller were excluded to avoid unexpected behavior.
cuongnmtm
force-pushed
the
imp-web_remember_tree_column_width-scss-selector
branch
from
cce3461 to
dd81906
Compare
|
I updated the commit message, thanks @luisg123v . |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 18ed6ad. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #2717
Technical note: