[17.0][MIG] hr_timesheet_task_domain: Migration to 17.0 #721

victoralmau · 2024-11-06T11:24:02Z

Migration to 17.0

Please @pilarvargas-tecnativa and @carlos-lopez-tecnativa can you review it?

[ADD] icon.png [UPD] Update hr_timesheet_task_domain.pot

Translated using Weblate (German) Currently translated at 100.0% (1 of 1 strings) Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_task_domain/de/

It's `project.task.type`, not `project.stage`.

Translated using Weblate (French) Currently translated at 75.0% (3 of 4 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_domain/fr/

Currently translated at 100.0% (4 of 4 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_domain/fr/

Translated using Weblate (Italian) Currently translated at 100.0% (1 of 1 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_domain/it/

[UPD] Update hr_timesheet_task_domain.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_domain/

Currently translated at 100.0% (2 of 2 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_domain/it/

Currently translated at 100.0% (2 of 2 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_domain/es/ [UPD] README.rst

Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (2 of 2 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_domain/pt_BR/

hr_timesheet_task_domain/models/account_analytic_line.py

carlos-lopez-tecnativa

@victoralmau I've updated my review. I noticed that the hr_timesheet_sheet module explicitly adds a domain in the view, and it works fine in other places. Apologies for the confusion.

What are your thoughts on using the state field instead of the stage_id.folded field?

timesheet/hr_timesheet_sheet/views/hr_timesheet_sheet_views.xml

Line 183 in 48658a1

domain="[('project_id', '=', project_id)]"

victoralmau · 2024-11-06T15:51:47Z

What are your thoughts on using the state field instead of the stage_id.folded field?

IMO that would be totally wrong, the state field is a text field that does not allow us to filter what we are really interested in, the stages that have been defined as fold (totally customized according to the ones that have been defined, there is not only 'Done').

pilarvargas-tecnativa · 2024-11-11T09:22:53Z

ping @carlos-lopez-tecnativa

carlos-lopez-tecnativa · 2024-11-11T15:14:37Z

What are your thoughts on using the state field instead of the stage_id.folded field?

IMO that would be totally wrong, the state field is a text field that does not allow us to filter what we are really interested in, the stages that have been defined as fold (totally customized according to the ones that have been defined, there is not only 'Done').

I understand your point. I was just referring to the new flow introduced in Odoo 17. If you check the Open Task filter, it uses the state field, regardless of whether the stage is folded or not, and the README mentions "Open."

But to avoid delaying the merge further, I'm okay with proceeding as is.

OCA-git-bot · 2024-11-11T15:19:42Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2024-11-11T16:12:26Z

Yes, indeed the move on Odoo is a bit weird, but anyway, let's keep this module with the previous approach. Let's just rephrase the README to mention folded stages instead of open tasks.

pedrobaeza

Uhm, checking again the original Odoo PR specs: odoo/odoo#107593, we would twist the expected way of working relying on stages, so let's switch to the states, and we will fill the gap with a module setting the state when changing the stage.

victoralmau · 2024-11-12T08:24:19Z

Changes done.

carlos-lopez-tecnativa

I may be missing something, as this should theoretically work. However, this project has three tasks—one closed and two open—yet nothing is being displayed.

TT51531

carlos-lopez-tecnativa

LGTM, thanks!

pedrobaeza

/ocabot migration hr_timesheet_task_domain
/ocabot merge nobump

OCA-git-bot · 2024-11-12T18:20:33Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-721-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-11-12T18:20:34Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-11-12T18:27:40Z

Congratulations, your PR was merged at 6fbd000. Thanks a lot for contributing to OCA. ❤️

alexey-pelykh and others added 17 commits November 6, 2024 12:13

[ADD] hr_timesheet_task_domain: task domain depends on project

cd6e614

[ADD] icon.png [UPD] Update hr_timesheet_task_domain.pot

[FIX] hr_timesheet_task_domain: Incorrect model name

6b8db1d

It's `project.task.type`, not `project.stage`.

[IMP] hr_timesheet_task_domain: black, isort

5f46486

[MIG] hr_timesheet_task_domain: Migration to 13.0

a1ae920

[UPD] Brainbean Apps => CorporateHub

2990cc3

[IMP] hr_timesheet_task_domain: isort, black, prettier

004f443

[MIG] Migrate module hr_timesheet_task_domain to v14.

6760c96

[MIG] hr_timesheet_task_domain: Migration to 15.0

942dddc

Translated using Weblate (French)

2f5013e

Currently translated at 100.0% (4 of 4 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_domain/fr/

Translated using Weblate (Italian)

04a6d02

Currently translated at 100.0% (2 of 2 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_domain/it/

[IMP] hr_timesheet_task_domain: pre-commit auto fixes

4a52979

carlos-lopez-tecnativa suggested changes Nov 6, 2024

View reviewed changes

hr_timesheet_task_domain/models/account_analytic_line.py Show resolved Hide resolved

pilarvargas-tecnativa approved these changes Nov 6, 2024

View reviewed changes

carlos-lopez-tecnativa reviewed Nov 6, 2024

View reviewed changes

carlos-lopez-tecnativa approved these changes Nov 11, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 11, 2024

pedrobaeza requested changes Nov 11, 2024

View reviewed changes

OCA-git-bot removed the approved label Nov 11, 2024

OCA-git-bot removed the ready to merge label Nov 11, 2024

victoralmau force-pushed the 17.0-mig-hr_timesheet_task_domain branch from 1ebefbc to d457fb7 Compare November 12, 2024 08:21

victoralmau mentioned this pull request Nov 12, 2024

[17.0][MIG] project_task_stage_state: Migration to 17.0 OCA/project#1366

Merged

carlos-lopez-tecnativa reviewed Nov 12, 2024

View reviewed changes

[MIG] hr_timesheet_task_domain: Migration to 17.0

c51cdfd

TT51531

victoralmau force-pushed the 17.0-mig-hr_timesheet_task_domain branch from d457fb7 to c51cdfd Compare November 12, 2024 16:49

victoralmau requested a review from carlos-lopez-tecnativa November 12, 2024 16:49

carlos-lopez-tecnativa approved these changes Nov 12, 2024

View reviewed changes

pedrobaeza approved these changes Nov 12, 2024

View reviewed changes

OCA-git-bot added the approved label Nov 12, 2024

OCA-git-bot added this to the 17.0 milestone Nov 12, 2024

OCA-git-bot mentioned this pull request Nov 12, 2024

Migration to version 17.0 #617

Open

13 tasks

OCA-git-bot added the ready to merge label Nov 12, 2024

OCA-git-bot added the bot is merging ⏳ label Nov 12, 2024

OCA-git-bot merged commit 84494cf into OCA:17.0 Nov 12, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 12, 2024

pedrobaeza deleted the 17.0-mig-hr_timesheet_task_domain branch November 12, 2024 18:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] hr_timesheet_task_domain: Migration to 17.0 #721

[17.0][MIG] hr_timesheet_task_domain: Migration to 17.0 #721

victoralmau commented Nov 6, 2024 •

edited

Loading

carlos-lopez-tecnativa left a comment

victoralmau commented Nov 6, 2024

pilarvargas-tecnativa commented Nov 11, 2024

carlos-lopez-tecnativa commented Nov 11, 2024

OCA-git-bot commented Nov 11, 2024

pedrobaeza commented Nov 11, 2024

pedrobaeza left a comment

victoralmau commented Nov 12, 2024

carlos-lopez-tecnativa left a comment

carlos-lopez-tecnativa left a comment

pedrobaeza left a comment

OCA-git-bot commented Nov 12, 2024

OCA-git-bot commented Nov 12, 2024

OCA-git-bot commented Nov 12, 2024

[17.0][MIG] hr_timesheet_task_domain: Migration to 17.0 #721

[17.0][MIG] hr_timesheet_task_domain: Migration to 17.0 #721

Conversation

victoralmau commented Nov 6, 2024 • edited Loading

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

victoralmau commented Nov 6, 2024

pilarvargas-tecnativa commented Nov 11, 2024

carlos-lopez-tecnativa commented Nov 11, 2024

OCA-git-bot commented Nov 11, 2024

pedrobaeza commented Nov 11, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

victoralmau commented Nov 12, 2024

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 12, 2024

OCA-git-bot commented Nov 12, 2024

OCA-git-bot commented Nov 12, 2024

victoralmau commented Nov 6, 2024 •

edited

Loading