Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] sale_timesheet_timeline: Dates planning in sales order lines #708

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

pedrobaeza
Copy link
Member

This module allows to plan in advance the start/end dates and assignees for the sales order lines that are services, and they are transferred to the created task (if any) when confirming the order.

It includes a timeline view for pre-viewing and managing the planning.

imagen

imagen

@Tecnativa TT50569

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 20, 2024
@pedrobaeza pedrobaeza changed the title [ADD] sale_timesheet_timeline: Dates planning in sales order lines [16.0][ADD] sale_timesheet_timeline: Dates planning in sales order lines Aug 20, 2024
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Tested 👍

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_timesheet_timeline branch from f05b170 to fe78817 Compare August 21, 2024 07:17
@pilarvargas-tecnativa
Copy link

I have added a new view that extends the order view of the portal to show a separate table with the data of the lines that have a planning set up. This is shown in a new section in the view called ‘Planning’.

image

@chienandalu If you want you can check again

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_timesheet_timeline branch 2 times, most recently from ed17e79 to eb71e77 Compare August 21, 2024 08:17
@pedrobaeza pedrobaeza force-pushed the 16.0-add-sale_timesheet_timeline branch 2 times, most recently from 14e5f80 to 660a452 Compare August 26, 2024 13:16
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments

Comment on lines 65 to 80
<field
name="task_date_start"
optional="hide"
attrs="{'invisible': [('product_type', '!=', 'service')]}"
/>
<field
name="task_date_end"
optional="hide"
attrs="{'invisible': [('product_type', '!=', 'service')]}"
/>
<field
name="task_user_ids"
optional="hide"
widget="many2many_avatar_user"
attrs="{'invisible': [('product_type', '!=', 'service')]}"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can edit a record when the sale order is confirmed, then these changes must be propagated to the task. Otherwise, we should block edits when the sale order is confirmed. What do you think?

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza

This comment was marked as resolved.

@pedrobaeza pedrobaeza force-pushed the 16.0-add-sale_timesheet_timeline branch 4 times, most recently from 7dd120c to 55a1261 Compare October 10, 2024 15:36
pedrobaeza and others added 2 commits October 10, 2024 17:41
This module allows to plan in advance the start/end dates and assignees for the sales
order lines that are services, and they are transferred to the created task (if any)
when confirming the order.

It includes a timeline view for pre-viewing and managing the planning.

TT50569
@pedrobaeza pedrobaeza force-pushed the 16.0-add-sale_timesheet_timeline branch from 55a1261 to d89d672 Compare October 10, 2024 15:41
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-708-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1923381 into OCA:16.0 Oct 10, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 53760a9. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-add-sale_timesheet_timeline branch October 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants