Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] sale_timesheet_line_exclude: add security group #707

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[16.0][IMP] sale_timesheet_line_exclude: add security group #707

merged 2 commits into from
Oct 9, 2024

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Aug 18, 2024 •
edited
Loading

closes #705

This should be merged with a minor or major version bump as it adds a security group that will need to be added to relevant users in order to preserve functionality.

@sbidoul sbidoul force-pushed the 16.0-sale_timesheet_line_exclude-security-sbi branch from 8b8d638 to ced87f4 Compare August 18, 2024 11:50
@sbidoul sbidoul added this to the 16.0 milestone Aug 18, 2024
@sbidoul sbidoul mentioned this pull request Aug 18, 2024
Open
alexey-pelykh
alexey-pelykh requested changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth mentioning this in the README.

sale_timesheet_line_exclude/security/exclude_from_sale_order.xml Outdated Show resolved Hide resolved
@sbidoul sbidoul force-pushed the 16.0-sale_timesheet_line_exclude-security-sbi branch from ced87f4 to 696663f Compare August 18, 2024 12:00
@sbidoul sbidoul requested a review from alexey-pelykh August 18, 2024 12:01
@alexey-pelykh
Copy link
Contributor

I feel like you didn't add the file you wanted to add :)

@sbidoul
Copy link
Member Author

sbidoul commented Aug 18, 2024

I feel like you didn't add the file you wanted to add :)

What do you mean?

@sbidoul sbidoul force-pushed the 16.0-sale_timesheet_line_exclude-security-sbi branch from 696663f to 34a29d3 Compare August 18, 2024 12:05
@sbidoul
Copy link
Member Author

sbidoul commented Aug 18, 2024

Ah, the README, updated now.

@alexey-pelykh alexey-pelykh changed the title [IMP] sale_timesheet_line_exclude: add security group [16.0][IMP] sale_timesheet_line_exclude: add security group Aug 18, 2024
@sbidoul
[FIX] sale_timesheet_line_exclude: don't copy the field
9f25a38 
We don't copy the field by default, because it breaks the
OE timesheet grid for users in the security group that hides
the field.

Functionally, it also makes sens to not copy this field,
because it is better to consider the new line not excluded
by default.
@sbidoul
Copy link
Member Author

sbidoul commented Aug 22, 2024

I discovered a bug where the security group breaks the timesheet grid, which attemps to copy timesheet lines.

So I declare the field copy=False, which makes sense since we normally want the copied lines to be "not excluded" by default.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member Author

sbidoul commented Oct 9, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-707-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 85e928b into OCA:16.0 Oct 9, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at daa5981. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 16.0-sale_timesheet_line_exclude-security-sbi branch October 9, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbrito gbrito gbrito approved these changes

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sbidoul @alexey-pelykh @OCA-git-bot @gbrito