Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] hr_timesheet_time_type_cost_rule #688

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

Christian-RB
Copy link

This module extends the functionality of project time type, providing the ability to apply cost rules to timesheet entries.

@Christian-RB Christian-RB force-pushed the 16.0-add-hr_timesheet_time_type_cost_rule branch from 03ebb28 to bbb76f6 Compare June 13, 2024 16:15
@arielbarreiros96
Copy link

It looks good to me, I successfully tested the feature on runbot, the costs apply accordingly to the time type and the rules for each time type. The domains for applying the rules also seems to work properly 👌

Copy link

@arielbarreiros96 arielbarreiros96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goot to me

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Christian-RB Christian-RB force-pushed the 16.0-add-hr_timesheet_time_type_cost_rule branch from bbb76f6 to 7f34710 Compare July 8, 2024 12:39
@Christian-RB Christian-RB force-pushed the 16.0-add-hr_timesheet_time_type_cost_rule branch from 7f34710 to fa56a3a Compare July 8, 2024 12:45
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
@@ -0,0 +1 @@
This module extends the functionality of project time type, providing the ability to apply cost rules to timesheet entries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand on what a "cost rule" is and what it is useful for (an example use case)?

Copy link

@arielbarreiros96 arielbarreiros96 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A “cost rule” is a way to define costs per hour type. In Odoo it is fairly easy to define the hourly cost per employee, but this only takes into account cases where the hourly cost is fixed per employee. It is also true that you can set an hourly cost related to an SO line, but this is only useful if the timesheet is related to a sales order line, and it is only possible to define one hourly cost per employee per SO line. Let's imagine this scenario:

A company that repairs heavy machinery for ships, industry, etc, 24/7 with field service, etc. Its employees work in shifts, and the shifts can vary so a particular employee does not always take the same shifts each week. The cost to the company varies from employee to employee, and from shift to shift. They may need to record timesheets and record costs based on the shift (regular hour, holidays, night shift, etc.) and the employee who worked at it, because employees will work on whatever machine (lets consider one project/analytic account per machine) is there when they start their shift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants