[18.0][MIG] stock_no_negative: Migration to 18.0 #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanRijnhart
requested changes
Feb 5, 2025
| @@ -11,7 +11,7 @@ | |||
| <field name="inherit_id" ref="stock.view_template_property_form" /> | |||
| <field name="arch" type="xml"> | |||
| <field name="categ_id" position="after"> | |||
| <field name="allow_negative_stock" invisible="type != 'product'" /> | |||
| <field name="allow_negative_stock" invisible="type == 'service'" /> | |||
There was a problem hiding this comment.
not is_storable, I think. See odoo/odoo@728d9f83f6d14
There was a problem hiding this comment.
Also, might be a nice improvement to move the field until after is_storable itself.
woutswennen
force-pushed
the
18.0-mig-stock_no_negative
branch
from
9bfe541 to
69bdcdf
Compare
|
/ocabot migration stock_no_negative |
rousseldenis
requested changes
Feb 26, 2025
There was a problem hiding this comment.
@woutswennen You should follow migration guide here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch
Especially, you should keep commits history.
Thanks
|
Wait, this is not the migration, it's a fix of the migration. @woutswennen Please update commit message and PR name accordingly. |
|
Also, duplicate of #1766 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oca module didnt work as we where not able to sellect the allow_negative_stock field on product