Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] stock_valuation_layer_accounting_date: update tests #2239

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[16.0][FIX] stock_valuation_layer_accounting_date: update tests #2239

merged 1 commit into from
Feb 6, 2025

Conversation

AungKoKoLin1997
Copy link
Contributor

This PR fixes the tests to ensure the same timezone is used for both create_date and accounting_date.

@qrtl QT5096

nobuQuartile
nobuQuartile approved these changes Jan 28, 2025
View reviewed changes
Copy link

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yostashiro
yostashiro reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Please take this chance to remove product template from self.product1.product_tmpl_id.categ_id.property_valuation = "manual_periodic".

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-imp-test-stock_valuation_layer_accounting_date branch from 08eb4ce to af87640 Compare January 28, 2025 03:02
@AungKoKoLin1997
Copy link
Contributor Author

@oca/stock-logistics-warehouse-maintainers
Can we get this PR merged?

@rousseldenis
Copy link
Contributor

@AungKoKoLin1997 Could you put module name in commit message ? Thanks

image

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-imp-test-stock_valuation_layer_accounting_date branch from af87640 to b5372c8 Compare February 6, 2025 01:56
@AungKoKoLin1997
Copy link
Contributor Author

Could you put module name in commit message ?

@rousseldenis Done!

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2239-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eac75cf into OCA:16.0 Feb 6, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9b37226. Thanks a lot for contributing to OCA. ❤️

@nobuQuartile nobuQuartile mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostashiro yostashiro yostashiro approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@nobuQuartile nobuQuartile nobuQuartile approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AungKoKoLin1997 @OCA-git-bot @rousseldenis @yostashiro @nobuQuartile